fix(app): bug dock auto-dismisses when session vanishes externally (amicode#296) - #151
Merged
Merged
Conversation
…micode#296) Layer 2 of the fix: a reactive liveness effect watches the synced session map — if the dock's current sessionID disappears (arm-failure cleanup by the extension, or any unexpected deletion), auto-dismiss silently. No new HTTP calls; rides the existing serverSync subscription. No toast (the extension already showed one). This prevents the composer from wedging in bug-report mode after the extension deletes a session that failed to arm.
jeonghun-jj-lee
force-pushed
the
amico/issue-296-bug-dock-preflight
branch
from
August 9, 2026 03:31
9cb80bf to
aec89c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layer 2 of the bug-dock wedge fix (amicode#296): a reactive liveness effect in
session-bug-dock.tsxwatches the synced session map. If the dock's currentsessionIDdisappears fromserverSync().session.data.info(because the extension deleted it after a failed arm), the dock auto-dismisses silently — no user action required, no wedged composer.Changes
packages/app/src/pages/session/composer/session-bug-dock.tsxcreateEffectthat fires when the dock is in"chat"phase: if the sessionID is no longer in the synced session map, callscontroller.requestClose()serverSyncsubscriptionCompanion PR
Testing
tsc --noEmit: cleanCloses harmoniqs/amicode#296